Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9733#discussion_r45052370
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -120,7 +120,7 @@ private[sql] object JDBCRDD extends Logging {
val dialect = JdbcDialects.get(url)
val conn: Connection = getConnector(properties.getProperty("driver"),
url, properties)()
try {
- val rs = conn.prepareStatement(s"SELECT * FROM $table WHERE
1=0").executeQuery()
+ val rs = conn.createStatement.executeQuery(s"SELECT * FROM $table
WHERE 1=0")
--- End diff --
Ah hang on a sec, I see you've changed some non-DDL statements in this
version of the PR. The change is just about avoiding `PreparedStatement` for
DDL right? My earlier comments were about closing resources for a bunch of
queries including non-DDL. But if you're only addressing DDL, then your last PR
was fine (before it was corrupted).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
