Github user smola commented on a diff in the pull request:
https://github.com/apache/spark/pull/8746#discussion_r45063997
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLTestSuite.scala ---
@@ -113,4 +113,23 @@ class DDLTestSuite extends DataSourceTest with
SharedSQLContext {
assert(attributes.map(_.name) === Seq("col_name", "data_type",
"comment"))
assert(attributes.map(_.dataType).toSet === Set(StringType))
}
+
+ test("SPARK-7012 Create table statement should support NOT NULL modifier
for columns") {
+ withTempPath { dir =>
+ val path = dir.getCanonicalPath
+ sql(
+ s"""
+ |CREATE TEMPORARY TABLE tempTableDDL
+ |( tCol1 INT NOT NULL,
+ | tCol2 STRING
+ |)
+ |USING parquet
+ |OPTIONS (
+ | path '$path'
+ |)
+ """.stripMargin
+ )
+ caseInsensitiveContext.dropTempTable("tempTableDDL")
--- End diff --
@sabhyankar Do you have time to modify this? I think that once the test is
improved with @cloud-fan comment, the change is probably good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
