Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9776#issuecomment-157507608
Unrelated failure.
This LGTM.
My only comment is that the implementation assumes we won't add many Param
types support by the default jsonEncode. That seems reasonable. (If we wanted
to support more in the future, we might want a designated type field to specify
the type being loaded.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
