Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1314#discussion_r14609276
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
    @@ -139,6 +140,17 @@ private[spark] object UIUtils extends Logging {
     
       def prependBaseUri(basePath: String = "", resource: String = "") = 
uiRoot + basePath + resource
     
    +  val commonHeaderNodes =
    +      <meta http-equiv="Content-type" content="text/html; charset=utf-8" />
    +      <link rel="stylesheet" 
href={prependBaseUri("/static/bootstrap.min.css")}
    +            type="text/css" />
    +      <link rel="stylesheet" href={prependBaseUri("/static/webui.css")}
    +            type="text/css" />
    +      <script src={prependBaseUri("/static/sorttable.js")} ></script>
    +      <script 
src={prependBaseUri("/static/jquery-1.11.1.min.js")}></script>
    +      <script 
src={prependBaseUri("/static/bootstrap-tooltip.js")}></script>
    +      <script 
src={prependBaseUri("/static/initialize-tooltips.js")}></script>
    --- End diff --
    
    nit: could you wrap this in a `{ }`, right now it's a little scary because 
this is all DSL, so it's not clear if we suddenly drop a few lines here and 
there


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to