Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/1262#discussion_r14611517
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -51,19 +52,8 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener {
var totalShuffleRead = 0L
var totalShuffleWrite = 0L
- // TODO: Should probably consolidate all following into a single hash
map.
- val stageIdToTime = HashMap[Int, Long]()
- val stageIdToShuffleRead = HashMap[Int, Long]()
- val stageIdToShuffleWrite = HashMap[Int, Long]()
- val stageIdToMemoryBytesSpilled = HashMap[Int, Long]()
- val stageIdToDiskBytesSpilled = HashMap[Int, Long]()
- val stageIdToTasksActive = HashMap[Int, HashMap[Long, TaskInfo]]()
- val stageIdToTasksComplete = HashMap[Int, Int]()
- val stageIdToTasksFailed = HashMap[Int, Int]()
- val stageIdToTaskData = HashMap[Int, HashMap[Long, TaskUIData]]()
- val stageIdToExecutorSummaries = HashMap[Int, HashMap[String,
ExecutorSummary]]()
- val stageIdToPool = HashMap[Int, String]()
- val stageIdToDescription = HashMap[Int, String]()
+ val stageUIData = new HashMap[Int, StageUIData]
--- End diff --
This name is confusing, especially a few lines below you have `val
stageData = ... new StageUIData`. We should call this `stageIdToData` or
something
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
