Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9787#discussion_r45154495
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -529,7 +530,12 @@ class Dataset[T] private[sql](
* For Java API, use [[collectAsList]].
* @since 1.6.0
*/
- def collect(): Array[T] = rdd.collect()
+ def collect(): Array[T] = {
+ val tEnc = resolvedTEncoder
+ val input = queryExecution.analyzed.output
+ val bound = tEnc.bind(input)
+ queryExecution.toRdd.map(_.copy()).collect().map(bound.fromRow)
--- End diff --
hmm, it looks to me that the only difference between this and `Dataset.rdd`
is you add a `copy` here, should we remove `Dataset.rdd`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
