Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9779#discussion_r45154563
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala ---
@@ -119,5 +123,66 @@ class TaskResultGetterSuite extends SparkFunSuite with
BeforeAndAfter with Local
// Make sure two tasks were run (one failed one, and a second retried
one).
assert(scheduler.nextTaskId.get() === 2)
}
+
+ /**
+ * SPARK-11195
+
+ * Make sure we are using the context classloader when deserializing
failed TaskResults instead
+ * of the Spark classloader.
+
+ * This test compiles a jar containing an exception and tests that when
it is thrown on the
+ * executor, enqueueFailedTask can correctly deserialize the failure and
identify the thrown
+ * exception as the cause.
+
+ * Before this fix, enqueueFailedTask would throw a
ClassNotFoundException when deserializing
+ * the exception, resulting in an UnknownReason for the TaskEndResult.
+ */
+ test("failed task deserialized with the correct classloader") {
--- End diff --
I would put the `(SPARK-11195)` in the test name to be consistent with
other tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
