Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/9790#issuecomment-157622191
Rather than enforcing ordering, isn it cleaner to capture the passed
arguments to `wal.write`, deserialize and compare as sets?
Its cleaner because the unit test should test whether all the data is
actually written or not, even when submitted concurrently.
Actually, you dont need to use custom mockito matcher (that would be ugly).
ArgumentCaptors are much less ugly I think. See
[link](http://stackoverflow.com/questions/5981605/can-mockito-capture-arguments-of-a-method-called-multiple-times).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
