GitHub user willb opened a pull request:

    https://github.com/apache/spark/pull/1323

    Fix (some of the) warnings in the test suite

    This PR fixes three classes of compiler and deprecation warnings in the 
test suite:
    
    * `expectResult` is currently deprecated and has been replaced with 
`assertResult`;
    * assertions of the form `should be ===` are deprecated in favor of the 
form `shouldEqual`; and
    * `scala.language.postfixOps` was not in scope within the test classes in 
which postfix operations were actually used.
    
    The fixes for these issues were almost entirely mechanical, but they 
eliminate many lines of warning output.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/willb/spark testCleanups

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1323
    
----
commit b05304666eb61d7d1d1849772c27cf9711699dae
Author: William Benton <[email protected]>
Date:   2014-07-07T20:31:27Z

    Replace expectResult with assertResult
    
    Assertions.expectResult is deprecated.  This commit replaces
    expectResult invocations with the assertResult invocations.

commit 5377534fdfe741aab7d6d539573ab78636bfd554
Author: William Benton <[email protected]>
Date:   2014-07-07T20:37:53Z

    Replaced deprecated 'be ===' assertions
    
    "should be ===" assertions have been deprecated in favor of
    "shouldEqual" assertions.  This commit replaces the deprecated
    form with the supported form.

commit a672a9b5d579c4946a20fe4c6f88c4582949ef3f
Author: William Benton <[email protected]>
Date:   2014-07-07T21:00:58Z

    Ensure language.postfixOps is in scope where used
    
    Previously, language.postfixOps was imported at toplevel, which meant
    compiler warnings since it wasn't visible inside the classes that used
    postfix operations.  This commit moves the import to suppress these
    warnings.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to