Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/9785#issuecomment-157787523
So my take on this is as follows:
1. If we have have the same name but different parameter types when
compared to base R then we should make sure the base R command works correctly.
This is the case for things like `subset`, `summary` etc. FWIW I think this
should be the most common scenario.
2. If we have same name and same parameter types (for example in `lag`): I
think we can override the behavior but we need to be more careful in these
cases. My guess is this mostly happens only when column names are passed as
strings and we could stop supporting that if we resolve
[SPARK-7499](https://issues.apache.org/jira/browse/SPARK-7499). For the
specific case of `lag` I think we are fine as the base `lag` isn't meant to be
used with characters as far as I can see.
3. If we have same name but the param types completely don't match (and no
room for `...`) then we override those functions but (This is true for
`sample`, `table`, `cov` right now I guess) we should try to limit the number
of functions where we do this. Also we should revisit some of these to see if
we can avoid it (for example `table` can be renamed ?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
