Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9802#discussion_r45236253
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
 ---
    @@ -517,29 +517,39 @@ case class GetInternalRowField(child: Expression, 
ordinal: Int, dataType: DataTy
       }
     }
     
    -/** Serializes an input object using Kryo serializer. */
    -case class SerializeWithKryo(child: Expression) extends UnaryExpression {
    +/**
    + * Serializes an input object using a generic serializer (Kryo or Java).
    + * @param kryo if true, use Kryo. Otherwise, use Java.
    + */
    +case class EncodeUsingSerializer(child: Expression, kryo: Boolean) extends 
UnaryExpression {
    --- End diff --
    
    It doesn't have to be this PR, but we should consider just passing the 
`Serializer` in as a literal since we already have a well defined interface.  
This way we could use user defined serializers too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to