Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9796#discussion_r45238295
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -408,7 +408,8 @@ private[spark] class ExecutorAllocationManager(
           executorsPendingToRemove.add(executorId)
           true
         } else {
    -      logWarning(s"Unable to reach the cluster manager to kill executor 
$executorId!")
    +      logWarning(s"Unable to reach the cluster manager to kill executor 
$executorId!" +
    +        s"Or no executor to kill!")
    --- End diff --
    
    Two things about this now:
    
    - the message reads a little bit weirdly. How about: "Unable to send kill 
request for $executorId to cluster manager, or executor is busy."
    
    - warning seems bit strong when the most probable cause of returning false 
is that the executor is busy; if there's a failure in sending a message to the 
cluster manager, I'm sure we'll see error / warning logs from other parts of 
the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to