Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9809#discussion_r45276079
--- Diff:
core/src/main/scala/org/apache/spark/util/SparkUncaughtExceptionHandler.scala
---
@@ -46,6 +46,15 @@ private[spark] object SparkUncaughtExceptionHandler
}
}
+ def log(thread: Thread, exception: Throwable): Unit = {
+ val errMsg = "Uncaught exception in thread "
+
+ // Make it explicit that uncaught exceptions are thrown when container
is shutting down.
+ // It will help users when they analyze the executor logs
+ val inShutdownMsg = if (ShutdownHookManager.inShutdown()) "[Container
in shutdown] " else ""
+ logError(inShutdownMsg + errMsg + thread, exception)
--- End diff --
this doesn't have to be its own method. I would just inline it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
