Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9297#discussion_r45305793
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala 
---
    @@ -104,21 +104,39 @@ private class LongSQLMetricParam(val stringValue: 
Seq[Long] => String, initialVa
       override def zero: LongSQLMetricValue = new 
LongSQLMetricValue(initialValue)
     }
     
    +private[sql] object LongSQLMetricParam extends 
LongSQLMetricParam(_.sum.toString, 0L)
    --- End diff --
    
    Nit: change the object name `LongSQLMetricParam ` to something else? 
Compare to `StaticsLongSQLMetricParam`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to