Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4887#issuecomment-158161862
> if we call (1) after this line, it will release memory for other unrolled
failed block. if we call (2), we can't got the specific memory for that
MEMORY_AND_DISK block.
What do you mean "other unrolled failed block"? Each thread only unrolls 1
block at a time, so why can't we call `releaseUnrollMemoryForThisThread`? We
know the caller of `unrollSafely` will not consume the array any further after
we wrote it to disk, so the array will be garbage collected eventually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
