Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9726#discussion_r45398570
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -736,39 +645,4 @@ trait ScalaReflection {
assert(methods.length == 1)
methods.head.getParameterTypes
}
-
- def typeOfObject: PartialFunction[Any, DataType] = {
--- End diff --
Probably fine in this case, but this isn't related to the undoing of the
refactoring and mixing concerns makes the PR much harder to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
