Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8880#discussion_r45415521
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala ---
@@ -81,12 +82,19 @@ private[spark] class DiskBlockObjectWriter(
*/
private var numRecordsWritten = 0
+ private var sparkConf: SparkConf = null
--- End diff --
Why not make this a constructor argument? You can have an overloaded
constructor so you don't have to change all the existing call sites. Then this
can be a `val`, and you don't need the setter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
