GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/9854
[SPARK-11871] Add save/load for MLPC
https://issues.apache.org/jira/browse/SPARK-11871
Here is a problem. Unlike other models in ML package extend from
`XXXParams` as with their estimators, the
`MultilayerPerceptronClassificationModel` does not extend from the
`MultilayerPerceptronParams`. So we cannot test all parameters in the test
suite because the `MultilayerPerceptronClassificationModel` plains for not
finding the parameters such as `maxIter`, `layers`.
However, it is reasonable because users do not need to set those parameters
in a MLPC model. But the inconsistency with other models makes the test suite
different. Maybe I can split the `testEstimatorAndModelReadWrite ` into two
parts in the test suite. I.e. test the estimator and model seperately. @mengxr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yinxusen/spark SPARK-11871
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9854
----
commit 949db7372f889d5bacd08b315e223163492f9138
Author: Xusen Yin <[email protected]>
Date: 2015-11-20T03:09:58Z
add save/load for MLPC
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
