Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9851#discussion_r45438806
--- Diff: mllib/src/test/scala/org/apache/spark/ml/util/TempDirectory.scala
---
@@ -35,11 +35,11 @@ trait TempDirectory extends BeforeAndAfterAll { self:
Suite =>
override def beforeAll(): Unit = {
super.beforeAll()
- _tempDir = Utils.createTempDir(this.getClass.getName)
+ _tempDir = Utils.createTempDir(namePrefix = this.getClass.getName)
}
override def afterAll(): Unit = {
- Utils.deleteRecursively(_tempDir)
+ Utils.deleteRecursively(_tempDir.getParentFile)
--- End diff --
Do we still need to remove parent? Now the root is `${java.io.tmp}`, which
is created by default and the temp directory is `o.a.s.ml.feature.ABC-UUID`. So
we should only remove `_tempDir` instead of its parent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
