Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9839#discussion_r45439309
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ---
@@ -189,7 +189,6 @@ object StandardScalerModel extends
MLReadable[StandardScalerModel] {
sqlContext.read.parquet(dataPath)
.select("std", "mean", "withStd", "withMean")
.head()
- // This is very likely to change in the future because withStd and
withMean should be params.
--- End diff --
If `withMean` and `withStd` are parameters, we should save them in
`metadata/` but not both under `data/` and `medadata/`. Can we change the
constructor of `ml.StandardScalerModel` to take only `std` and `mean` but
construct `scaler` only inside `transform`? So `scaler` is no longer a member
variable. We can fix performance issues in 1.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
