GitHub user dskrvk opened a pull request:
https://github.com/apache/spark/pull/9867
[SPARK-6990] [Build] Add Java linting script; mix minor warnings
This replaces https://github.com/apache/spark/pull/9696
Invoke Checkstyle and print any errors to the console, failing the step.
Use Google's style rules modified according to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Some important checks are disabled (see TODOs in `checkstyle.xml`) due to
multiple violations being present in the codebase.
Suggest fixing those TODOs in a separate PR(s).
Also fix some of the minor violations that didn't require sweeping changes.
Apologies for the previous botched PRs - I finally figured out the issue.
cr: @JoshRosen, @pwendell
> I state that the contribution is my original work, and I license the work
to the project under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dskrvk/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9867.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9867
----
commit 38a00078a73173f953e1de2230148b8973941572
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-10T16:56:46Z
[SPARK-6990] Add Java linting script
Invoke Checkstyle and print any errors to the console, failing the step.
Use Google's style rules modified according to
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
Some important checks are disabled (see TODOs in checkstyle.xml) due to
multiple violations being present in the codebase.
commit 10465b567bd3c54562f9ecc8bc9778126571dc7d
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-13T16:53:16Z
[SPARK-6990] Remove whitespace after '>'
Closing '>' and method name shouldn't have whitespace between them,
according
to
http://checkstyle.sourceforge.net/config_whitespace.html#GenericWhitespace
commit 1a57e30be00b07ccba0c9e7412370b685cd92014
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-10T16:57:20Z
[SPARK-6990] Fix some Checkstyle warnings
commit 59c99c996416927722dcd499d4c5f7634b283f91
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T14:52:19Z
[SPARK-6990] Suppress Checkstyle for TimSort
The code was copied from a third-party source and needs to be in sync with
that, so we shouldn't make our own modifications to it.
The file contains some style violations, so suppress the checks.
commit d33ed8de691ee4d411febe15f77766f97397d260
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T14:58:41Z
[SPARK-6990] Fix some Checkstyle issues in tests
commit 7d5cbe163115a8ee170a867ba74476aa31286958
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T15:01:20Z
[SPARK-6990] Enable Checkstyle for tests
commit b96a61a3a447b15015853f7349a84d1fe503b972
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-11T15:01:48Z
[SPARK-6990] Enable FallThrough check in Checkstyle
This makes sure all case statements end with a break. See
http://checkstyle.sourceforge.net/config_coding.html#FallThrough
commit db17e0e3bc98de89e644e273604abdad04265328
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-19T21:20:34Z
[SPARK-6990] Disable MissingSwitchDefault check
Checks fails in UnsafeRowParquetRecordReader.java. Let's enable the check
in a
separate change.
commit ae30c6a1cf52f1b313f6cdb9d456703c8207a5b3
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-19T21:25:24Z
[SPARK-6990] Fix qualifier order in SpecificParquetRecordReaderBase
commit fd6d0e0a640b76c9f95f25fb2ab756b645efc69f
Author: Dmitry Erastov <[email protected]>
Date: 2015-11-20T19:47:24Z
Merge remote-tracking branch 'upstream/master'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
