Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8610#discussion_r45551887
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -639,10 +640,11 @@ private[deploy] class Master(
         // in the queue, then the second app, etc.
         for (app <- waitingApps if app.coresLeft > 0) {
           val coresPerExecutor: Option[Int] = app.desc.coresPerExecutor
    +      val coreNumPerTask = app.desc.coresPerTask
    --- End diff --
    
    nitpick: `coreNumPerTask` sounds weird.  `coresPerTaks` is what you've used 
everywhere else, and the name above is `coresPerExecutor`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to