GitHub user saurfang opened a pull request:

    https://github.com/apache/spark/pull/9896

    [SPARK-11906][Web UI] Speculation Tasks Cause ProgressBar UI Overflow

    When there are speculative tasks in the stage, running progress bar could 
overflow and goes hidden on a new line:
    
![image](https://cloud.githubusercontent.com/assets/4317392/11326841/5fd3482e-9142-11e5-8ca5-cb2f0c0c8964.png)
    3 completed / 2 running (including 1 speculative) out of 4 total tasks
    
    This is a simple fix by capping the started tasks at `total - completed` 
tasks
    
![image](https://cloud.githubusercontent.com/assets/4317392/11326842/6bb67260-9142-11e5-90f0-37f9174878ec.png)
    
    I should note my preferred way to fix it is via css style
    ```css
    .progress { display: flex; }
    ```
    which shifts the correction burden from driver to web browser. However I 
couldn't get selenium test to measure the position/dimension of the progress 
bar correctly to get this unit tested. 
    
    It also has the side effect that the width will be calibrated so the 
running occupies 2 / 5 instead of 1 / 4.
    
![image](https://cloud.githubusercontent.com/assets/4317392/11326848/7b03e9f0-9142-11e5-89ad-bd99cb0647cf.png)
    
    All in all, since this cosmetic bug is minor enough, I suppose the original 
simple fix should be good enough.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/saurfang/spark progressbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9896.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9896
    
----
commit 55942cb2dda4e10f518c32186aea54029b7eceda
Author: Forest Fang <[email protected]>
Date:   2015-11-22T22:51:43Z

    started + completed should < total for progressbar

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to