Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9861#discussion_r45622542
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -489,6 +492,13 @@ private[sql] class JDBCRDD(
}
try {
if (null != conn) {
+ if (!conn.getAutoCommit && !conn.isClosed) {
+ try {
+ conn.commit()
+ } catch {
+ case e: Exception => logWarning("Exception committing
transaction", e)
--- End diff --
Was just thinking of using `finally`, and bringing the inner `if` statement
inside the `try` to keep it tidy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
