Github user radekg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9608#discussion_r45681436
  
    --- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
    @@ -42,10 +42,11 @@ private[spark] class HttpFileServer(
         fileDir.mkdir()
         jarDir.mkdir()
         logInfo("HTTP File server directory is " + baseDir)
    -    httpServer = new HttpServer(conf, baseDir, securityManager, 
requestedPort, "HTTP file server")
    +    httpServer = new HttpServer(conf, baseDir, securityManager, 
requestedPort, "HTTP file server", Some("spark.fileserver.advertisedPort"))
    --- End diff --
    
    @tnachen before I start modifying the pr, I read that the AkkaRpcEnv is 
planned to be removed in favour of NettyRpcEnv in 1.6.0. Is this still planned?
    If so, it might be worth for me to look at that at thesame time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to