Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9793#discussion_r45699105
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -489,10 +495,6 @@ public void loadNext() throws IOException {
}
upstream = nextUpstream;
nextUpstream = null;
-
- assert(inMemSorter != null);
--- End diff --
What I meant to say is that my understanding of the old `free()` call here
was performed when we hit the final record of the iterator, so I thought we'd
still need / want to free the iterator at that point even in the new code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
