Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9895#discussion_r45722497
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -535,6 +535,14 @@ class HiveContext private[hive](
         ).map { case (confVar, unit) =>
           confVar.varname -> hiveconf.getTimeVar(confVar, unit).toString
         }.toMap
    +
    +    // SPARK-11783 When "hive.metastore.uris" is set, it overrides 
"javax.jdo.option.ConnectionURL",
    +    // thus the execution Hive client connects to the actual remote Hive 
metastore instead of the
    +    // Derby metastore created in the temporary directory.  Cleaning this 
configuration for
    +    // the execution Hive client fixes this issue.
    +    timeConfVars ++ Seq(
    +      ConfVars.METASTOREURIS.varname -> ""
    --- End diff --
    
    Sorry, made a stupid mistake here... It should be added in 
`HiveContext.newTemporaryConfigurations()` Unfortunately I couldn't figure out 
a way to add a regression test for this change since it requires a remote Hive 
metastore to test. I was verifying the result by remote debugging and checking 
the internal underlying Hive metastore client instance of `executionHive`. 
Somehow came to the wrong conclusion :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to