Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45781057
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -85,7 +85,7 @@ final class CategoricalSplit private[ml] (
/**
* If true, then "categories" is the set of categories for splitting to
the left, and vice versa.
*/
- private val isLeft: Boolean = _leftCategories.length <= numCategories / 2
+ private[ml] val isLeft: Boolean = _leftCategories.length <=
numCategories / 2
/** Set of categories determining the splitting rule, along with
[[isLeft]]. */
private val categories: Set[Double] = {
--- End diff --
Should we maybe do this in a second change? It seems like if there aren't
that many categories for one direction then this would maybe not be a great
change. What are your thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
