Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9939#discussion_r45784681
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
 ---
    @@ -33,7 +33,7 @@ import org.apache.spark.rdd.RDD
     @Since("1.6.0")
     @Experimental
     class BisectingKMeansModel @Since("1.6.0") (
    -    @Since("1.6.0") val root: ClusteringTreeNode
    +    @Since("1.6.0")private[clustering] val root: ClusteringTreeNode
    --- End diff --
    
    @yu-iskw Can you confirm if you meant this to be public?  It may not be 
necessary since most users will just call predict, computeCost, etc.  What do 
you think?  It does expose a much larger API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to