Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/6935#issuecomment-159434408
This is a converged patch which
1. Splits out all caching into `ApplicationCache`, for isolation and
testing.
1. Now asks the history server (which then asks the HistoryProvider) to see
if an app has changed. If so, it triggers a refresh.
1. Includes the metrics counting requests and timing probe/getAppUI calls,
so when a descendant of #9571 goes in, the cache is instrumented. Those
counters are used in the tests to check internal cache state BTW, not without
immediate use.
1. The test there is test at the cache level, with a stub implementation of
the operations the history server has to do. Its incomplete (need one to verify
that on cache eviction the UIs are detached).
There's nothing for spark UI tests (there's the template above there), or
the REST API
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
