Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9889#discussion_r45824083
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -579,11 +580,50 @@ class Dataset[T] private[sql](
        */
       def takeAsList(num: Int): java.util.List[T] = 
java.util.Arrays.asList(take(num) : _*)
     
    +
    +  /* ******* *
    +   *  Cache  *
    +   * ******* */
    +
    +  /**
    +    * @since 1.6.0
    +    */
    --- End diff --
    
    The comment style here is off and we should actually have a description.  
Could we just move the functions/docs from DataFrame to Queryable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to