Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9921#discussion_r45833828
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -185,17 +185,23 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
val ds2 = Seq(1, 2).toDS().as("b")
checkAnswer(
- ds1.joinWith(ds2, $"a.value" === $"b.value"),
+ ds1.joinWith(ds2, $"a.value" === $"b.value", "inner"),
(1, 1), (2, 2))
}
- test("joinWith, expression condition") {
- val ds1 = Seq(ClassData("a", 1), ClassData("b", 2)).toDS()
- val ds2 = Seq(("a", 1), ("b", 2)).toDS()
+ test("joinWith, expression condition, outer join") {
+ val nullInteger = null.asInstanceOf[Integer]
+ val nullString = null.asInstanceOf[String]
+ val ds1 = Seq(ClassNullableData("a", new Integer(1)),
--- End diff --
nit: we can just pass in `1`, and compile will auto box for us.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
