GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/9971
[SPARK-11893] Model export/import for spark.ml: TrainValidationSplit
https://issues.apache.org/jira/browse/SPARK-11893
@jkbradley In order to share read/write with `TrainValidationSplit`, I move
the `SharedReadWrite` out of `CrossValidator` into a new trait
`SharedReadWrite` in the tunning package.
To reduce the repeated tests, I move the complex tests from
`CrossValidatorSuite` to `SharedReadWriteSuite`, and create a fake validator
called `MyValidator` to test the shared code.
With `SharedReadWrite`, potential newly added `Validator` can share the
read/write common part, and only need to implement their extra params save/load.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yinxusen/spark SPARK-11893
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9971
----
commit c3e73b422aa97de37c88e1f12caf090b1c6aecbf
Author: Xusen Yin <[email protected]>
Date: 2015-11-25T09:28:12Z
move shared read/write out
commit 7f3428a37596f6ddc90a331746c71af4042a76be
Author: Xusen Yin <[email protected]>
Date: 2015-11-25T10:32:33Z
fix params errors
commit cdc41b706329b8aa5469c4aebf57aa18296af78d
Author: Xusen Yin <[email protected]>
Date: 2015-11-25T11:20:55Z
add fake validator test
commit bb5423e0eaef913443c8acb07d28c80bfa66eb11
Author: Xusen Yin <[email protected]>
Date: 2015-11-25T11:30:19Z
simplify cross validation test save/load
commit 15d0df6c41bb8b37fb06accce5d4a68634293f9c
Author: Xusen Yin <[email protected]>
Date: 2015-11-25T11:35:58Z
add TrainValidationSplitSuite
commit 71355cabe2bab792a3bc43e61a66f0a361e21580
Author: Xusen Yin <[email protected]>
Date: 2015-11-25T11:43:03Z
change 1.6 to 1.7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
