Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9878#issuecomment-159691639
Yes, I think it's correct now. My only question is if we should explicitly
unpersist the broadcast vars after synAgg is created (by a collect, so it
should be safe to unpersist then). I don't really know how quickly they would
be cleaned up after going out of scope. (Do you?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
