Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7753#discussion_r45921896
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -205,7 +231,14 @@ private[spark] class EventLoggingListener(
override def onBlockUpdated(event: SparkListenerBlockUpdated): Unit = {}
// No-op because logging every update would be overkill
- override def onExecutorMetricsUpdate(event:
SparkListenerExecutorMetricsUpdate): Unit = { }
+ override def onExecutorMetricsUpdate(event:
SparkListenerExecutorMetricsUpdate): Unit = {
+ // In order to avoid the logged event consumes too much storage size,
taskMetrics would not
+ // be logged into event log file currently
+ val lightEvent = SparkListenerExecutorMetricsUpdate(
--- End diff --
the comment above the method is inaccurate (this is no longer a no-op
obviously). Can you change it something like "Track executor metrics for
logging on stage start and end".
I'd also update the inner comment to something like "We only track the
executor metrics in each stage, so we drop the task metrics as they are quite
verbose". and maybe rename "lightEvent" to "eventWithoutTaskMetrics"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
