Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9989#discussion_r45960187
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
    @@ -600,12 +600,15 @@ object Word2VecModel extends Loader[Word2VecModel] {
           val vectorSize = model.values.head.size
           val numWords = model.size
           val metadata = compact(render
    -        (("class" -> classNameV1_0) ~ ("version" -> formatVersionV1_0) ~
    -         ("vectorSize" -> vectorSize) ~ ("numWords" -> numWords)))
    +      (("class" -> classNameV1_0) ~ ("version" -> formatVersionV1_0) ~
    +        ("vectorSize" -> vectorSize) ~ ("numWords" -> numWords)))
           sc.parallelize(Seq(metadata), 
1).saveAsTextFile(Loader.metadataPath(path))
     
    +      val partitionSize = 33554432l //32MB
    --- End diff --
    
    `1 << 25`? Can you explain the rationale in a quick comment here, and what 
41 comes from?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to