Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9937#issuecomment-159973463
Thanks for working on this. I'm not sure that this is the right tactic
though. I don't think that we want to make java bean the default fall back in
our scala reflection code path. Instead I think that we only want to create a
java bean encoder when the user explicitly asks for it and thus this should be
a separate code path. The only common code should be `ExpressionEncoder`
probably.
Also, instead of hacking this into scala's reflection, I think we should
use the builtin java support for introspecting on beans. I would probably
start with the code in
[JavaTypeInference](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala)
and use that to construct expressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
