Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9840#discussion_r46002027
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
 ---
    @@ -235,12 +236,13 @@ case class ExpressionEncoder[T](
     
         val plan = Project(Alias(unbound, "")() :: Nil, LocalRelation(schema))
         val analyzedPlan = SimpleAnalyzer.execute(plan)
    +    val optimizedPlan = SimplifyCasts(analyzedPlan)
    --- End diff --
    
    Probably not a `SQLContext` but a `CatalystConfig` would be reasonable.  I 
wonder if it should be a different setting than SQL case sensitivity resolution?
    
    On one hand, Scala/Java are always case sensitive so it seems reasonable to 
preserve that.  On the other hand if you loading from something like hive it 
would be annoying to have to fix all the columns by hand.
    
    @rxin, thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to