Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9990#discussion_r46007594
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -401,7 +402,7 @@ class SQLContext private[sql](
*/
@Experimental
def createDataFrame[A <: Product : TypeTag](rdd: RDD[A]): DataFrame = {
- SparkPlan.currentContext.set(self)
+ SparkPlan.currentContext.set(new WeakReference[SQLContext](self))
--- End diff --
A `WeakReference` is quite weak; you'll lose the reference on a full GC. Is
this not going to cause the code to fail suddenly? I don't know that references
are any remedy for a leak.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
