Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10009#discussion_r46015873
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -104,16 +104,13 @@ class CodeGenContext {
val equivalentExpressions: EquivalentExpressions = new
EquivalentExpressions
// State used for subexpression elimination.
- case class SubExprEliminationState(
- isLoaded: String,
- code: GeneratedExpressionCode,
- fnName: String)
+ case class SubExprEliminationState(isNull: String, value: String)
// Foreach expression that is participating in subexpression
elimination, the state to use.
val subExprEliminationExprs = mutable.HashMap.empty[Expression,
SubExprEliminationState]
- // The collection of isLoaded variables that need to be reset on each
row.
- val subExprIsLoadedVariables = mutable.ArrayBuffer.empty[String]
+ // The collection of variables that need to be reset on each row.
--- End diff --
how about `The collection of sub-exression result reset method that need to
be called on each row.`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
