Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9654#discussion_r46084477
  
    --- Diff: R/pkg/R/types.R ---
    @@ -41,3 +41,11 @@ COMPLEX_TYPES <- list(
     
     # The full list of data types.
     DATA_TYPES <- as.environment(c(as.list(PRIMITIVE_TYPES), COMPLEX_TYPES))
    +
    +# An environment for mapping R to Scala, names are R types and values are 
Scala types.
    +rToSQLTypes <- new.env()
    --- End diff --
    
    Can we follow the same style as above ? `as.environment(list())`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to