Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10019#discussion_r46087115
--- Diff: R/pkg/R/functions.R ---
@@ -1250,7 +1250,7 @@ setMethod("upper",
#'}
setMethod("var",
signature(x = "Column"),
- function(x, y = NULL, na.rm = FALSE, use) {
+ function(x) {
--- End diff --
Correct, since the generic is set properly.
There's a test in test_sparkSQL.R for stats::var with the y param
```
> var(1:5, 1:5)
[1] 2.5
> var(1:5, 1:5, na.rm=T)
[1] 2.5
```
Extra param `y`, `na.rm` can still be passed when calling `var` on a Column
but they are ignored (just as before)
I discover this while working on #9785 for `lag`
https://github.com/apache/spark/pull/9785/files#diff-d97f9adc2dcac0703568c799ff106987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
