Github user liyezhang556520 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7753#discussion_r46153585
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -228,6 +261,46 @@ private[spark] class EventLoggingListener(
fileSystem.rename(new Path(logPath + IN_PROGRESS), target)
}
+ /**
+ * According to the updated event to modify the maintained event's
metrics
+ * @param executorId the executor whose metrics will be modified
+ */
+ private def updateModifiedMetrics(executorId: String): Unit = {
+ val toBeModifiedEvent = executorIdToModifiedMaxMetrics.get(executorId)
+ val latestEvent = executorIdToLatestMetrics.get(executorId)
+ toBeModifiedEvent match {
+ case None => if (latestEvent.isDefined)
executorIdToModifiedMaxMetrics.update(
+ executorId, latestEvent.get)
--- End diff --
@squito , I'm sorry I made a mistake here, you are really careful. Thank
you correct me again. You are right that `executorIdToLatestMetrics` will be
updated before we call `updateModifiedMetrics`, I'll remove the `if` statement.
Sorry to mislead you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
