Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10009#discussion_r46177905
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -417,18 +413,12 @@ class CodeGenContext {
val code = expr.gen(this)
val fn =
s"""
- |private void $fnName(InternalRow ${INPUT_ROW}) {
- | if (!$isLoaded) {
--- End diff --
Am I right in saying you've picked a different approach to do this? You
removed isLoaded and just load it every time. I think this is scary because it
does not allow shortcircuiting. This can be bad if it is expr1 AND expr2 and
expr1 is selective or expr2 is expensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
