Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10042#discussion_r46182492
--- Diff:
core/src/main/scala/org/apache/spark/util/ShutdownHookManager.scala ---
@@ -232,22 +232,23 @@ private [util] class SparkShutdownHookManager {
}
}
- def runAll(): Unit = synchronized {
+ def runAll(): Unit = {
shuttingDown = true
- while (!hooks.isEmpty()) {
- Try(Utils.logUncaughtExceptions(hooks.poll().run()))
+ var nextHook: SparkShutdownHook = null
+ while ({nextHook = hooks synchronized { hooks.poll() }; nextHook !=
null}) {
+ Try(Utils.logUncaughtExceptions(nextHook.run()))
}
}
- def add(priority: Int, hook: () => Unit): AnyRef = synchronized {
+ def add(priority: Int, hook: () => Unit): AnyRef = {
checkState()
val hookRef = new SparkShutdownHook(priority, hook)
- hooks.add(hookRef)
+ hooks synchronized { hooks.add(hookRef) }
--- End diff --
Yeah, you got me. That really has to be tightened up. Will address these
shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
