Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/1309#discussion_r14695146
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -809,12 +810,24 @@ class DAGScheduler(
listenerBus.post(SparkListenerStageCompleted(stageToInfos(stage)))
runningStages -= stage
}
+
event.reason match {
case Success =>
logInfo("Completed " + task)
if (event.accumUpdates != null) {
// TODO: fail the stage if the accumulator update fails...
Accumulators.add(event.accumUpdates) // TODO: do this only if
task wasn't resubmitted
+ event.accumUpdates.foreach { case (id, partialValue) =>
+ val acc = Accumulators.originals(id)
+ val name = acc.name
+ // To avoid UI cruft, ignore cases where value wasn't updated
--- End diff --
Do you think this will make things hard to debug -- e.g., if someone's
accumulator doesn't show up in the UI and they don't realize it's because the
value wasn't updated as opposed to because they didn't set the show-in-ui
variable correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
