Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9297#discussion_r46203981
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1332,9 +1337,13 @@ object SQLContext {
* Create a SQLListener then add it into SparkContext, and create an
SQLTab if there is SparkUI.
*/
private[sql] def createListenerAndUI(sc: SparkContext): SQLListener = {
- val listener = new SQLListener(sc.conf)
- sc.addSparkListener(listener)
- sc.ui.foreach(new SQLTab(listener, _))
- listener
+ if (sqlListener.get() == null) {
--- End diff --
Also, is the only purpose of `sqlListener` to prevent multiple listeners
from being created at the same time? If so, I think it would be better to use
an AtomicBoolean so that we don't create another strong reference to a
SQLListener, which might have a lot of internal state that could lead to memory
leaks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
