Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9858#discussion_r46209620
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
    @@ -488,6 +488,12 @@ private[sql] case class EnsureRequirements(sqlContext: 
SQLContext) extends Rule[
       }
     
       def apply(plan: SparkPlan): SparkPlan = plan.transformUp {
    +    case operator @ Exchange(partitioning, child, _) =>
    +      child.children match {
    +        case Exchange(childPartitioning, baseChild, _)::Nil =>
    --- End diff --
    
    The key difference about putting it in the planner instead of in the 
optimizer is that you can actually plan the child first and check its actual 
output ordering instead of doing this specific check for `Aggregate`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to