Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10048#discussion_r46210267 --- Diff: project/SparkBuild.scala --- @@ -155,13 +155,15 @@ object SparkBuild extends PomBuild { if (major.toInt >= 1 && minor.toInt >= 8) Seq("-Xdoclint:all", "-Xdoclint:-missing") else Seq.empty }, + // TODO(thunterdb) how to set these based on the current version of the JVM? javacJVMVersion := "1.7", scalacJVMVersion := "1.7", javacOptions in Compile ++= Seq( - "-encoding", "UTF-8", - "-source", javacJVMVersion.value, - "-target", javacJVMVersion.value + "-encoding", "UTF-8" + // TODO(thunterdb) make it conditional for <= "1.7" --- End diff -- I am not sure how to get the current version of java (not the target version).
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org