Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10066#discussion_r46270863
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/CassandraDialect.scala ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.jdbc
+
+import java.sql.Types
+
+import org.apache.spark.sql.types._
+
+
+private case object CassandraDialect extends JdbcDialect {
+
+ override def canHandle(url: String): Boolean =
+ url.startsWith("jdbc:datadirect:cassandra") ||
+ url.startsWith("jdbc:weblogic:cassandra")
+
+ override def getInsertStatement(table: String, rddSchema: StructType):
String = {
+ val sql = new StringBuilder(s"INSERT INTO $table ( ")
+ var fieldsLeft = rddSchema.fields.length
+ var i = 0
+ // Build list of column names
+ while (fieldsLeft > 0) {
+ sql.append(rddSchema.fields(i).name)
+ if (fieldsLeft > 1) sql.append(", ")
--- End diff --
Nits: braces and newline for the `if`; use `a += 1` instead of `a = a + 1`
in the two lines below; extra blank line above near the imports.
You should probably also make this more idiomatic and compact. For example
this `while` loop collapses to `rddSchema.fields.map(_.name).mkString(", ")`, I
believe. Similarly for the final `while`. And then the entire method doesn't
need to manually build it up with `StringBuilder`. This is probably a couple
lines of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
